tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: WebSocket status
Date Thu, 01 Mar 2012 15:03:17 GMT

> I have a draft patch [1] that seems to fix this. A similar change would
> be required for the Comet part of Poller.processKey()
>
> Thoughts and/or comments? Not knowing the NIO code very well, there
> might be a better way to achieve the same result that I haven't seen.
>
> Mark
>
> [1] http://people.apache.org/~markt/patches/draft/2012-03-01-trunk-nio.patch

I took a look at the patch. IMHO it's not the right way to go. You're adding in flags to compensate
for the state machine in the selector. 
And by doing so, you will have the selector run more than it needs to, cause you have read
interest turned on, on sockets that you are 
already processing, wasting CPU cycles.

Filip

>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message