Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4F39881C.4070606@christopherschultz.net>
Date: Mon, 13 Feb 2012 17:01:00 -0500
From: Christopher Schultz <chris@christopherschultz.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: Custom rules for commons-digester
References: <4F397C79.1070907@christopherschultz.net>
 <CABzHfV=cZYc5kFMkLiS-SCdFE_x_f4=FKk1ptaZMwKmijO1XFw@mail.gmail.com>
In-Reply-To: 
 <CABzHfV=cZYc5kFMkLiS-SCdFE_x_f4=FKk1ptaZMwKmijO1XFw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigB82E650D6CD0C51D8670058A"

--------------enigB82E650D6CD0C51D8670058A
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Konstantin,

On 2/13/12 4:32 PM, Konstantin Kolinko wrote:
> 2012/2/14 Christopher Schultz <chris@christopherschultz.net>:
>> All,
>>
>> There are 15 or so custom rule classes in the Tomcat sources for
>> handling various commons-digester events.
>>
>> I've only taken a brief glance at their content, but I'm wondering if =
we
>> can't replace these classes with an XML-based configuration that the
>> Digester itself can handle for us.
>>
>> Such a change would eliminate those classes form our own code base as
>> well as allow us to remove the package-renamed code from
>> commons-digester in SVN (of course, we'd still have to re-package
>> commons-digester for distribution, but at least we'd have less source =
to
>> deal with).
>>
>> Other than some logging (I can see, for instance, that
>> ConnectorCreateRule emits warnings when setter methods can't be found =
on
>> the target class), is there a compelling reason to have source-based
>> rules instead of configuration-based rules?
>=20
> They are faster.

Fair enough, but server.xml is processed only once on startup. Unless
you're seeing an insane performance increase, I would suggest that
maintainability might be more important than performance.

(This also assumes that maintaining an XML-based configuration file
represents less effort than maintaining the equivalent source code, but
as I said previously, it would allow us to purge our copies of the
Digester from our own svn repo as well, which I see as a win).

-chris


--------------enigB82E650D6CD0C51D8670058A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk85iBwACgkQ9CaO5/Lv0PBXigCfScxldXdz8gL55eQD3rUbeCdu
l/kAoMARCm2oaIHYsmwkdeQ8yZIbxs5Y
=KtKx
-----END PGP SIGNATURE-----

--------------enigB82E650D6CD0C51D8670058A--