tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52697] Response.recycle() does not always call outputStream.clear()
Date Fri, 17 Feb 2012 23:45:01 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52697

--- Comment #2 from J├Ârgen Rydenius <rydenius@gmail.com> 2012-02-17 23:45:01 UTC ---
(In reply to comment #1)
> (In reply to comment #0)
> > But logically, I think it would make more sense recycling the outputBuffer the last
thing.
> 
> No it doesn't.

Thank you very much Mark for your elaborate reply. I buy your reasoning in all
cases but one: you say it does not make any sense to call
outputBuffer.recycle() after outputStream.clear(). Clearing the output stream
after recycling the outputBuffer opens a window where a misbehaving application
can affect the already recycled outputBuffer. Clearing the outputStream first
would on the other hand disconnect the outputBuffer from the application before
recycling it, thus making it impossible for a misbehaving application to do
something stupid with it. That would in my humble opinion be a robustness
improvement.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message