tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52688] Added ability to have access logs output to standard logging mechanism
Date Fri, 17 Feb 2012 00:16:04 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52688

--- Comment #2 from Konstantin Kolinko <knst.kolinko@gmail.com> 2012-02-17 00:16:04
UTC ---
You can always create your own class that inherits from AccessLogValve() and
overrides
- open()
- close()
- log(String)

I think it could be possible to refactor AccessLogValve to extract output file
handling into helper class. Redirection to a logger might be an alternative
implementation of such helper.

I see the following weaknesses of proposed patch:

1. It does not prevent creation of access log files by the valve. It just
prints nothing to them, but the files will be created as usual.

2. Those "Fields/Version/Software" headers are specific to
ExtendedAccessLogValve, because they are part of "W3c Extended Log File Format"
format that it implements.
They are not needed in AccessLogValve. If you want to add them there, it would
be a separate feature.


For reference - see discussion on dev@ regarding viability of this approach,
"AccessLogValve enhancement"
- http://marc.info/?t=132934123800005&r=1&w=2
- http://tomcat.markmail.org/thread/iz67c2puilxv4leg

Note that using this feature requires specific logging configuration.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message