tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 51181] Add support for Web Sockets
Date Wed, 08 Feb 2012 08:33:37 GMT

--- Comment #30 from Mark Thomas <> 2012-02-08 08:33:37 UTC ---
The origin changes look good. I'll incorporate them shortly.

Regarding the changes to createWebSocketInbound, I understand passing the
protocol but why pass the HttpServletRequest as well?

Regarding the changes to the tests, I know we refer to them as unit tests but
we frequently test more widely than that to provide greater confidence in the
end to end processing chain. Unfortunately, that means we are going to need to
write some (very basic) form of WebSocket client to test things.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message