tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Drake <jdpr...@gmail.com>
Subject Re: WebSocket TODOs
Date Fri, 24 Feb 2012 06:15:55 GMT
On 2012/02/23 17:24, "Mark Thomas" <markt@apache.org> wrote:

>On 23/02/2012 12:42, Mark Thomas wrote:
>> All,
>> 
>> The bulk of the WebSocket implementation is complete. There are,
>> however, still quite a few TODOs.
>> 
>> 1. Autobahn failure of test 7.5.1 (close handling)
>Fixed.
>
>> 2. Autobahn UTF-8 failures. Invalid UTF-8 is not being detected by the
>> Reader. Needs further investigating.
>Fixed. (Thank you Apache Harmony).
>
>> 3. Autobhan performance failures. Not all these tests are completing.
>> Need to figure out why.
>The implementation is horribly slow. See point 6.


Ran into the same performance issues in our websocket branch. Found that
buffering the processor IO streams vastly improved performance.

Tried the same thing on the current trunk and got an order of magnitude
improvement.

The trunk as of now ran Autobahn 9.1.1 (64K payload) in about 500 ms,
and ran 9.1.5 (8M payload) in about 55 seconds. Case 9.1.6 (16M) fails.

But wrapping the [Input|Output]Streams in UpgradeBioProcessor
with Buffered[Input|Output]Streams gives the following:
9.1.1 (64K) ~120 ms (versus 500 ms)
9.1.5 (8M)  ~6 sec (versus 55 sec)
9.1.6 (16M) ~12 sec (versus >100 sec)

I haven't played with Upgrade[Nio/Apr]Processor to see how they behave.


>
>The rest are still TODO.
>
>Mark
>
>> 4. i18n. Fix all the TODOs and ensure there are no hard-coded English
>> messages.
>> 
>> 5. Threading. Fix the TODOs associated around multiple threads trying to
>> send messages at the same time.
>> 
>> 6. Profiling. Take a look with YourKit and Autobahn's performance tests.
>> If there are obvious bottlenecks, fix them.
>> 
>> 7. Add some documentation but mainly rely on the examples and the
>>Javadoc.
>> 
>> 
>> Once the above is complete, I intend back-porting the implementation to
>> 7.0.x.
>> 
>> I'd also like to see a lot more examples.



We wrote a nifty chat demo on our branch--will see about porting it to the
current trunk.



>> 
>> I will probably back-port the generic upgrade support first before the
>> above is complete.
>> 
>> Help with any/all of the above welcome.
>> 
>> Mark
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>> 
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>For additional commands, e-mail: dev-help@tomcat.apache.org
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message