tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Costin Manolache <cos...@gmail.com>
Subject Re: Release Tomcat Native 1.1.23
Date Wed, 22 Feb 2012 05:17:58 GMT
Mladen: please let me know if you want to further review the change or
should I merge it to the branch.

I also noticed there are few other diffs - in particular the 'interrupt'
stuff in poll, few others.
Any plans to merge them too ? What's the plan with the trunk ?

Costin

On Tue, Feb 21, 2012 at 3:29 PM, Mladen Turk <mturk@apache.org> wrote:

> On 02/21/2012 09:56 PM, Costin Manolache wrote:
>
>> On Tue, Feb 21, 2012 at 12:51 PM, Rainer Jung<rainer.jung@kippdata.de>**
>> wrote:
>>
>>  On 21.02.2012 21:30, Costin Manolache wrote:
>>>
>>>  Is this going to be from head ? How can I get the NPN ( sslext.c )
>>>> included
>>>> ?
>>>>
>>>>
>>> Mladen is aiming for 1.1.23, so he will be releasing from the 1.1.x
>>> branch.
>>>
>>>
>> What's the process for backporting ? The main change is adding a file, so
>> it should be pretty safe.
>>
>>
> Not sure if that code is safe and I doubt it'll compile on all platforms,
> E.g
> TCN_IMPLEMENT_CALL(jint, SSLExt, setSessionData)(TCN_STDARGS, jlong
> tcsock, jbyteArray buf, jint len)
> {
> unsigned char bytes[len];
> ^^^
>
> This is not valid C code, although some compiler might allow it.
> You would need to use malloc for that buffer since the 'len' is not known
> in advance.
> BTW, what's the purpose of this code? Seems it requires java API as well,
> so
> not sure if that's present in all tomcat versions 1.1.23 is supposed to
> run.
> However if not used I don't care ;)
>
>
>
> Regards
> --
> ^TM
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.**org<dev-unsubscribe@tomcat.apache.org>
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message