tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Petr Praus <p...@praus.net>
Subject Re: WebSocket progress report
Date Thu, 16 Feb 2012 13:31:06 GMT
Thanks Johno Crawford for pointing out that attachments are stripped, I
uploaded the patch here: https://gist.github.com/1844837

On Wed, Feb 15, 2012 at 22:01, Petr Praus <petr@praus.net> wrote:

> Hello, attached is our patch. It applies cleanly on top of current trunk
> rev. 1244719. It has rudimentary support for fragmentation (callback after
> last frame), supports close messages and ping/pong. Sorry for not sending a
> patchset but I thought it wouldn't really make sense, since there were
> quite a lot of back and forth changes. Let me know if I should send a
> patchset instead.
>
> (Jonathan's summary)
> "Echoing fragments. Close messages. Pings/pongs.
>
>     Just barely works. :) Fragmentation support is very limited: a mere
>     callback when last frame received. Sends normal closing reply messages
>     and some protocol error closes. Answers pings with pongs. Moving
>     towards a better application API. The servlet container is doing
>     something I don't understand with rapid connection attempts…not sure
>     what's up. I renamed StreamInbound to WebSocketConnection since it's
>     bidirectional. Also I gave the upgrade processors close() methods.
>     Fixed a number of bugs, including a switch statement with accidentally
>     cascading cases, and a problem with in Conversions.byteArrayToLong()."
>
> Thanks,
> Petr
>
>
> On Wed, Feb 15, 2012 at 17:17, Petr Praus <petr@praus.net> wrote:
>
>> Hi, sorry for the delay, we got stalled a little bit, I'll post the patch
>> today (US central time) after I manage to merge it (oh the cursed newlines).
>> Thanks,
>> Petr
>>
>>
>> On Mon, Feb 13, 2012 at 14:18, Christopher Schultz <
>> chris@christopherschultz.net> wrote:
>>
>>> Jeremy,
>>>
>>> On 2/10/12 12:08 PM, Jeremy Brown wrote:
>>> >> I suspect it will need more than that. The XLST will almost certainly
>>> >> need some tweaks too.
>>> >
>>> > How timely, I'm doing xml transformations in my SOA class right now.
>>>
>>> If you have any questions about XSLT, I'd be happy to answer them. It's
>>> definitely something that you have to have a Zenlike relationship with
>>> in order to do properly.
>>>
>>> Just like Lisp, it's possible to write really awful
>>> procedurally-oriented code with it, but then it just sucks horribly.
>>>
>>> We've been using XSLT for a long time with Apache Cocoon (such a great
>>> product) to transform XML into XHTML. I'd be happy to help.
>>>
>>> -chris
>>>
>>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message