tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r1292127 - /tomcat/native/trunk/native/src/sslext.c
Date Wed, 22 Feb 2012 08:08:28 GMT
On 02/22/2012 05:52 AM, costin@apache.org wrote:
> Author: costin
>
> +	if (len>  TCN_BUFFER_SZ) {
> +		return -1;
> +	}

Suppose that the len is presumed to always be shorter then 8K.

>
>   	char * requestedTicket = apr_pcalloc(tcssl->pool, len);

suppose this can be be just
jbyte *requestedTicket = apr_pcalloc(tcssl->pool, len);
so that you don't need to cast later to jbyte*.

>
> +	if (len>  TCN_BUFFER_SZ) {
> +		return -1;
> +	}

should be 'if (len >  TCN_BUFFER_SZ)'

Could you arrange the code style of this file.
I mean it uses tabs instead spaces, doesn't have spaces between operators,
C++ comments and so on.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message