tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: AccessLogValve enhancement
Date Tue, 21 Feb 2012 16:37:52 GMT
Mark,

On 2/19/12 12:49 PM, Mark Thomas wrote:
> On 19/02/2012 17:20, Christopher Schultz wrote:
>> Philosophically, I'm not really sure why the flexibility of a 
>> full-featured logging system (JULI, log4j, etc.) is required for
>> access logging: there's not much opportunity to use all the
>> features they provide (log level filtering, log-message aggregation
>> to log files and log-file multiplexing/splitting). Access logs
>> typically log one thing (accesses), log it all the time, and always
>> write to the same log file.
> 
>> I'm not adverse to the patch, I just don't really see a need for
>> it.
> 
> I was coming from the "I'd rather not maintain a bunch of code to
> solve a problem that the logging frameworks have already solved
> (threading, roll-over, output to multiple destinations)" angle.

That's something I hadn't really thought about, honestly. It's one of
the best reasons to use a logging framework IMO.

I'd like to see some performance metrics, though, since putting a
fully-fledged logging framework in the middle here has a distinct
possibility of slowing everything down (for every request, of course). I
kind of like Konstantin's idea of building extension-points into the
AccessLogValve to allow a particular implementation of the Valve to
handle the physical logging aspects while the AccessLogValve itself
takes care of actually generating and emitting the log messages. That
way, users can get the best of both worlds.

> You know me, always happy to delete some code from the Tomcat code
> base.

Amen, brother.

Multiple implementations certainly doesn't lead to that end, but we'll
see how things shake out.

> My main point is that it is something worthy of discussion. And that
> is what we are doing.

Absolutely.

-chris


Mime
View raw message