tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1240105 - in /tomcat/trunk/java/org/apache/catalina: Container.java core/ContainerBase.java core/StandardHost.java deploy/NamingResources.java mbeans/MBeanUtils.java realm/RealmBase.java startup/FailedContext.java valves/ValveBase.ja
Date Fri, 03 Feb 2012 12:24:45 GMT
On 03/02/2012 12:19, Konstantin Kolinko wrote:
> 2012/2/3  <markt@apache.org>:
>> +    @Override
>> +    public String getMBeanKeyProperties() {
>> +        Container c = this;
>> +        StringBuilder keyProperties = new StringBuilder();
>> +        int containerCount = 0;
>> +
>> +        // Work up container hierarchy, add a component to the name for
>> +        // each container
>> +        while (!(c instanceof Engine)) {
>> +            if (c instanceof Wrapper) {
>> +                keyProperties.append(",servlet=");
>> +                keyProperties.append(c.getName());
> 
> I think that the names should be wrapped by ObjectName.quote().
> Here and in similar method implemented in another class below.
> I do not think that there is a restriction that forbids ,;:= in a servlet name.

That is going to change the name Servlets are registered under. That
sort of change has caused problems for folks in the past. I recall
someone (rjung?) fixed a similar issue in the connectors but I can't
remember where or how off-hand.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message