Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1228066 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date: Fri, 06 Jan 2012 10:40:37 -0000
To: dev@tomcat.apache.org
From: rjung@apache.org
Message-Id: <20120106104037.4240E23888E7@eris.apache.org>

Author: rjung
Date: Fri Jan  6 10:40:36 2012
New Revision: 1228066

URL: http://svn.apache.org/viewvc?rev=1228066&view=rev
Log:
Vote and add a few comments.

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1228066&r1=1228065&r2=1228066&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan  6 10:40:36 2012
@@ -66,7 +66,7 @@ PATCHES PROPOSED TO BACKPORT:
   HTTP response code when rejecting denied request. E.g. 404 instead of 403.
   http://people.apache.org/~kkolinko/patches/2011-11-16_tc6_RequestFilterValve_denyStatus.patch
   (r1202565 in trunk, r1202570 in TC7)
-  +1: kkolinko
+  +1: kkolinko, rjung
   -1:
 
 * Reduce overhead from exception handling in UDecoder
@@ -84,7 +84,7 @@ PATCHES PROPOSED TO BACKPORT:
   chunked POST request is too large, but treat it like an IO error.
   http://svn.apache.org/viewvc?rev=1206200&view=rev
   (without tests; it is r1206205 in TC7)
-  +1: kkolinko,funkman
+  +1: kkolinko,funkman, rjung
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52293
@@ -93,32 +93,35 @@ PATCHES PROPOSED TO BACKPORT:
   Patch by Justin Miller
   https://issues.apache.org/bugzilla/attachment.cgi?id=28038&action=diff
   (https://issues.apache.org/bugzilla/attachment.cgi?id=28097&action=diff)
-  +1: markt, kkolinko
+  +1: markt, kkolinko, rjung
   -1:
+  rjung: It seems the change to line 976 is only an unwanted whitespace addition.
 
 * Backport SetCharacterEncodingFilter
   1) patch
    http://people.apache.org/~kkolinko/patches/2011-12-22_tc6_SetCharacterEncodingFilter.patch
   2)
    svn propset svn:eol-style native java/org/apache/catalina/filters/SetCharacterEncodingFilter.java
-  +1: kkolinko
+  +1: kkolinko, rjung
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52384
   Do not fail in Parameter parsing when debug logging is enabled.
   Also do not flag extra '&' as errors.
   http://svn.apache.org/viewvc?rev=1224659&view=rev
-  +1: kkolinko
+  +1: kkolinko, rjung
   -1:
 
 * Reduce log level for the message about hitting maxParameterCount limit
   from WARN to INFO.
-  in /java/org/apache/tomcat/util/http/Parameters.java line 242:
+  in java/org/apache/tomcat/util/http/Parameters.java line 242:
   - log.warn(sm.getString("parameters.maxCountFail",
   + log.info(sm.getString("parameters.maxCountFail",
   (backport of http://svn.apache.org/viewvc?rev=1224665&view=rev)
-  +1: kkolinko
+  +1: kkolinko, rjung
   -1:
+  rjung: Why do we compare "parameterCount >= limit" in line 240?
+         Shouldn't it be ">"?
 
 * Update to Apache Commons Pool 1.5.7
   In build.properties.default line 138:
@@ -129,7 +132,7 @@ PATCHES PROPOSED TO BACKPORT:
   pick up the changes, as in the usual "deploy" target there is no check
   that tomcat-dbcp.jar that has been built earlier used the specified
   versions of pool and dbcp.
-  +1: kkolinko
+  +1: kkolinko, rjung
   -1:
 
 
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org