From dev-return-123853-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Tue Jan 17 07:50:25 2012 Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 919119842 for ; Tue, 17 Jan 2012 07:50:25 +0000 (UTC) Received: (qmail 4912 invoked by uid 500); 17 Jan 2012 07:50:25 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 4370 invoked by uid 500); 17 Jan 2012 07:50:19 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 4321 invoked by uid 99); 17 Jan 2012 07:50:15 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2012 07:50:15 +0000 Received: from localhost (HELO mail-iy0-f173.google.com) (127.0.0.1) (smtp-auth username olamy, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2012 07:50:14 +0000 Received: by iaeo4 with SMTP id o4so10439068iae.18 for ; Mon, 16 Jan 2012 23:50:14 -0800 (PST) Received: by 10.50.161.135 with SMTP id xs7mr13700015igb.15.1326786614164; Mon, 16 Jan 2012 23:50:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.155.200 with HTTP; Mon, 16 Jan 2012 23:49:53 -0800 (PST) In-Reply-To: References: <4F136148.6050205@apache.org> <4F13F192.5020702@kippdata.de> <9586CA8A-5930-452C-B99D-793204B7E845@m4x.org> <4F148C52.6070308@apache.org> From: Olivier Lamy Date: Tue, 17 Jan 2012 08:49:53 +0100 Message-ID: Subject: Re: [VOTE] Release Apache Tomcat 7.0.24 To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 2012/1/17 Konstantin Kolinko : > 2012/1/17 Mark Thomas : >> On 16/01/2012 19:04, Sylvain Laurent wrote: >>> >>> On 16 janv. 2012, at 10:44, Rainer Jung wrote: >>>> >>>> 1) Unit test failure due to missing target directory in src dist >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> >>>> I noticed that test/webapp-3.0-virtual-library/target is missing from = the src dist. So when rebuilding from src dist and running unit tests, I ge= t a failure in TestVirtualContext, because some resource which is usually r= etrieved form the target dir is missing: >>>> >>>> Testcase: testVirtualClassLoader took 7.434 sec >>>> =A0 =A0 =A0 =A0FAILED >>>> expected:<200> but was:<404> >>>> junit.framework.AssertionFailedError: expected:<200> but was:<404> >>>> =A0 =A0 =A0 =A0at org.apache.catalina.loader.TestVirtualContext.assert= PageContains(TestVirtualContext.java:302) >>>> =A0 =A0 =A0 =A0at org.apache.catalina.loader.TestVirtualContext.assert= PageContains(TestVirtualContext.java:294) >>>> =A0 =A0 =A0 =A0at org.apache.catalina.loader.TestVirtualContext.testVi= rtualClassLoader(TestVirtualContext.java:100) >>>> >>>> AFAIK the root cause is, that we exclude **/target/** in the ant targe= t dist-source from being copied. >>>> >>>> Note that there is also test/webapp-3.0-virtual-library/target. >>>> >>>> I don't know, whether we can simply drop this exclude, or should renam= e the directory. I CC'd Sylvain explicitely, maybe he can comment on it. >>> >>> If there are no side effect to dropping this exclude, you may do it (I = really don't know enough of the build system of tomcat). >>> Otherwise I can rename those directories so that it is not excluded. Ju= st let me know. >> >> If I recall correctly, those directories are excluded because some IDEs >> use that name by default. If you could rename them that would be great. > > Not IDEs, but Maven. It writes its output into directories named > "target", in each of its modules. (I guess that is not configurable, > grr...) See http://maven.apache.org/ref/3.0.3/maven-model/maven.html#class_build directory element. :P > > That is why "target" was present in .gitignore when it was first added, > [1] http://svn.apache.org/viewvc?view=3Drevision&revision=3D1187740 > > This fault is a combination of mine > [2] http://svn.apache.org/viewvc?view=3Drevision&revision=3D1204938 > > that applied patterns from gitignore to src distribution and of Sylvain's > [3] http://svn.apache.org/viewvc?view=3Drevision&revision=3D1209731 > > when Sylvain removed that line from ".gitignore" > and used that name in his commit. > > > I am generally in favor of using more targeted patterns in "dist-source" = target, > (That is, comment out "**/target/**" for now, with a comment that we > use that name, > and add the same comment to .gitignore > and later exclude more specific patterns when a need comes) > but consider if one of developers used Maven to work on something in modu= les. > > Currently modules/jdbc-pool and modules/tomcat-lite have pom.xml, > though svn:ignore property on those directories does not list "target" > as excluded. > > Best regards, > Konstantin Kolinko > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > --=20 Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org