From dev-return-123857-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Tue Jan 17 09:03:52 2012 Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E8F99AA8 for ; Tue, 17 Jan 2012 09:03:52 +0000 (UTC) Received: (qmail 91623 invoked by uid 500); 17 Jan 2012 09:03:49 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 91536 invoked by uid 500); 17 Jan 2012 09:03:41 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 91504 invoked by uid 99); 17 Jan 2012 09:03:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2012 09:03:39 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of rainer.jung@kippdata.de designates 195.227.30.149 as permitted sender) Received: from [195.227.30.149] (HELO mailserver.kippdata.de) (195.227.30.149) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2012 09:03:29 +0000 Received: from [195.227.30.209] (notebook-rj [195.227.30.209]) by mailserver.kippdata.de (8.13.5/8.13.5) with ESMTP id q0H939c3020747 for ; Tue, 17 Jan 2012 10:03:09 +0100 (CET) Message-ID: <4F153947.9010504@kippdata.de> Date: Tue, 17 Jan 2012 10:03:03 +0100 From: Rainer Jung User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: dev@tomcat.apache.org Subject: Re: [VOTE] Release Apache Tomcat 7.0.24 References: <4F136148.6050205@apache.org><4F13F192.5020702@kippdata.de><9586CA8A-5930-452C-B99D-793204B7E845@m4x.org><4F148C52.6070308@apache.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 17.01.2012 02:15, Konstantin Kolinko wrote: > 2012/1/17 Mark Thomas: >> On 16/01/2012 19:04, Sylvain Laurent wrote: >>> >>> On 16 janv. 2012, at 10:44, Rainer Jung wrote: >>>> >>>> 1) Unit test failure due to missing target directory in src dist >>>> ================================================================ >>>> >>>> I noticed that test/webapp-3.0-virtual-library/target is missing from the src dist. So when rebuilding from src dist and running unit tests, I get a failure in TestVirtualContext, because some resource which is usually retrieved form the target dir is missing: >>>> >>>> Testcase: testVirtualClassLoader took 7.434 sec >>>> FAILED >>>> expected:<200> but was:<404> >>>> junit.framework.AssertionFailedError: expected:<200> but was:<404> >>>> at org.apache.catalina.loader.TestVirtualContext.assertPageContains(TestVirtualContext.java:302) >>>> at org.apache.catalina.loader.TestVirtualContext.assertPageContains(TestVirtualContext.java:294) >>>> at org.apache.catalina.loader.TestVirtualContext.testVirtualClassLoader(TestVirtualContext.java:100) >>>> >>>> AFAIK the root cause is, that we exclude **/target/** in the ant target dist-source from being copied. >>>> >>>> Note that there is also test/webapp-3.0-virtual-library/target. >>>> >>>> I don't know, whether we can simply drop this exclude, or should rename the directory. I CC'd Sylvain explicitely, maybe he can comment on it. >>> >>> If there are no side effect to dropping this exclude, you may do it (I really don't know enough of the build system of tomcat). >>> Otherwise I can rename those directories so that it is not excluded. Just let me know. >> >> If I recall correctly, those directories are excluded because some IDEs >> use that name by default. If you could rename them that would be great. > > Not IDEs, but Maven. It writes its output into directories named > "target", in each of its modules. (I guess that is not configurable, > grr...) > > That is why "target" was present in .gitignore when it was first added, > [1] http://svn.apache.org/viewvc?view=revision&revision=1187740 > > This fault is a combination of mine > [2] http://svn.apache.org/viewvc?view=revision&revision=1204938 > > that applied patterns from gitignore to src distribution and of Sylvain's > [3] http://svn.apache.org/viewvc?view=revision&revision=1209731 > > when Sylvain removed that line from ".gitignore" > and used that name in his commit. > > > I am generally in favor of using more targeted patterns in "dist-source" target, > (That is, comment out "**/target/**" for now, with a comment that we > use that name, > and add the same comment to .gitignore > and later exclude more specific patterns when a need comes) > but consider if one of developers used Maven to work on something in modules. Done in r1232345 (trunk) and r1232346 (tc7). > Currently modules/jdbc-pool and modules/tomcat-lite have pom.xml, > though svn:ignore property on those directories does not list "target" > as excluded. Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org