tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Release 2.0-beta-1 of Tomcat Maven Plugin
Date Tue, 10 Jan 2012 11:33:20 GMT
2012/1/5 Olivier Lamy <olamy@apache.org>:
> Hello,
> I'd like to release a first version of Tomcat Maven Plugin.
> As it's the first version here and some features have been added, this
> version will be called 2.0-beta-1.
>
> I will do that early next week.
>
> Let me know if you have any comments.
>

1. IIRC you had plans to reintroduce common "tomcat" plugin.

Are you going to go with separate "tomcat6" and "tomcat7" for now?


2. Reviewing some of your commits I noted that one of classes there uses
System.exit() calls. [1]

Is that OK? IMHO throwing some exception or an Error is a lot better
that using that call.

Some time ago Tomcat was also using System.exit() during shutdown, but
when it was noted that it caused problems with Commons Daemon and it
was changed to never call that method.

For a joke, someone mentioned [2] recently.

[1] http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java?view=markup

[2] http://thedailywtf.com/Articles/Serious-Failure.aspx

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message