tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Burch <br...@pingtoo.com>
Subject Re: svn commit: r1183612 [2/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Date Sat, 14 Jan 2012 02:30:53 GMT
On 14/01/12 09:45, Filip Hanik - Dev Lists wrote:
> No grudge held :)
> I'm just bringing it up since very many files have been reformatted for
> the sake of formatting. And when tracing down a problem, I, and I
> suspect others too, often use SVN history to figure out what and how
> changed. So a formatting change that makes satisfies a personal
> formatting preference for one developer, down the line can make it a lot
> harder to trace changes for others.

I don't want to throw petrol on glowing embers, and I realise my own 
efforts barely count. However, when I've been researching the history of 
changes in logic that I didn't fully understand, the svn history has 
been unhelpful and confusing. Now I understand why!

Brian

>
> Filip
>
> On 1/13/2012 3:34 PM, Konstantin Kolinko wrote:
>> 2012/1/14 Filip Hanik - Dev Lists<devlists@hanik.com>:
>>> Commits like this, make it very difficult to trace down changes in
>>> the SVN
>>> history.
>>> I know both Mark and Konstantin are very keen on formatting, to the
>>> point
>>> where it overrides the priority of tracing down changes.
>>> I may be alone, but I'd prefer that we don't do this mega format
>>> entire file
>>> for no apparent purpose commits anymore.
>> It is technical issue due to broken git-svn client that committed this
>> file with wrong line-ends (violating Subversion protocol).
>>
>> It was discussed here on dev@tomcat (and users@subversion) in October
>> 2011. It is nothing to grudge about.
>>
>> (Anyway to lookup the history further requires just several clicks in
>> viewvc to ask annotations starting with different revision.)
>>
>> http://tomcat.markmail.org/thread/f4rdxrjvrenc6tg6
>> http://subversion.markmail.org/thread/uovs5c7mgcnyp4an
>>
>>
>>> Filip
>>>
>>> On 10/15/2011 3:47 AM, kkolinko@apache.org wrote:
>>>> Modified:
>>>> tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1183612&r1=1183611&r2=1183612&view=diff
>>>>
>>>>
>>>> ==============================================================================
>>>>
>>>> --- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
>>>> (original)
>>>> +++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
>>>> Sat
>>>> Oct 15 09:47:39 2011
>>>> @@ -1,2514 +1,2514 @@
>>>> -/*
>>>> - * Licensed to the Apache Software Foundation (ASF) under one or more
>>>> - * contributor license agreements. See the NOTICE file distributed
>>>> with
>>>> - * this work for additional information regarding copyright ownership.
>>>> - * The ASF licenses this file to You under the Apache License, Version
>>>> 2.0
>>>> - * (the "License"); you may not use this file except in compliance
>>>> with
>>>> - * the License. You may obtain a copy of the License at
>>>> - *
>>>> - * http://www.apache.org/licenses/LICENSE-2.0
>>>> - *
>>>> - * Unless required by applicable law or agreed to in writing, software
>>>> - * distributed under the License is distributed on an "AS IS" BASIS,
>>>> - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>>> implied.
>>>> - * See the License for the specific language governing permissions and
>>>> - * limitations under the License.
>>>> - */
>> (no need to quote 2K of text)
>>
>> Best regards,
>> Konstantin Kolinko
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message