Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: softfail (nike.apache.org: transitioning domain of
 brian@pingtoo.com does not designate 217.154.193.216 as permitted sender)
Message-ID: <4EFC1B89.9090200@pingtoo.com>
Date: Thu, 29 Dec 2011 17:49:29 +1000
From: Brian Burch <brian@pingtoo.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.9.2.24) Gecko/20111108 Thunderbird/3.1.16
MIME-Version: 1.0
To: dev@tomcat.apache.org
Subject: Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module
 tomcat-trunk)
 failed
References: <20111228144033.DB97F14908E@vmgump.apache.org>
 <4EFBEA99.1020504@pingtoo.com> <jdgv44$na6$1@dough.gmane.org>
In-Reply-To: <jdgv44$na6$1@dough.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 29/12/11 15:50, Bill Barker wrote:
>

Thanks for looking at the two errors for me, Bill. It was hard to see 
your comments because the formatting of your reply appeared mangled when 
I received it. I have snipped out everything except the important bits 
below...

>
> "Brian Burch" wrote in message news:4EFBEA99.1020504@pingtoo.com...
>
> On 28/12/11 14:40, Bill Barker wrote:
>> To whom it may engage...
>
> This caught my attention, but I am puzzled (see details below).
>
> -----------------> Buildfile:
> /srv/gump/public/workspace/tomcat-trunk/build.xml>> download-validate:>>
> proxyflags:>> setproxy:>> testexist:> [echo] Testing
> for/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar>>
> downloadzip:>> validate:> [mkdir] Created
> dir:/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle>
> [checkstyle] Running Checkstyle 5.6-SNAPSHOT on 2099 files>
> [checkstyle]/srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java:27:
> Wrong order for'org.apache.catalina.Session' import.>>The sort order
> looks OK to me, but I am just a fallible human. Is this a case of
> Checkstyle being
> backlevel?>>http://sourceforge.net/tracker/?func=detail&atid=397078&aid=2952881&group_id=29721>>http://checkstyle.sourceforge.net/releasenotes.html>>says
> this bug was fixed in 5.2, and the log above implies we are using
> 5.6.>>I don't know how to fix the style error, but I can't help
> feeling responsible.

>The import is clearly out of order. It should go ahead of the
> other org.apache.catalina.xxx.yyy imports.

Thanks for explaining, Bill. It wasn't clear to me because I am not 
familiar with that particular checkstyle module.

> [checkstyle]/srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/authenticator/NonLoginAuthenticator.java:50:
> Line matches the >illegal pattern '\s+$'.>>line 50 currently appears to
> be trivial and identical to line 47, which is apparently considered to be
> acceptable!?! What is wrong?

>Running the validate target on Windows
> doesn't flag this one for me(admittedly using 5.5 checkstyle instead of
> 5.6-SNAPSHOT). At a guess,maybe it got a CRLF line ending somehow, so it
> gets flagged by Gump runningon Linux but not on Windows. Of course, it
> could also be due to using5.6-SNAPSHOT and a bug in checkstyle. I'm not
> interested enough to try itmyself on Linux, but that would be a check.

After checking out the latest source, I copy-n-pasted line 47 over the 
top of line 50 under linux, but svn diff does not detect the change.

/res/checkstyle/checkstyle.xml has the following test:

   <module name="RegexpSingleline">
     <!-- No trailing whitespace -->
     <property name="format" value="\s+$"/>
   </module>

... but I cannot see any trailing white space on line 50 (or 
48,49,51,52). Perhaps someone fixed it without me noticing?

>>
> BUILD FAILED>> /srv/gump/public/workspace/tomcat-trunk/build.xml:447:
> Got 2 errors and 0warnings.>>> Total time: 28 seconds>
> ---------------------------------------------

Would an authorised developer kindly apply the following patch to 
resolve the import order problem for me?

===================================================================
--- java/org/apache/catalina/authenticator/NonLoginAuthenticator.java 
(revision 1225420)
+++ java/org/apache/catalina/authenticator/NonLoginAuthenticator.java 
(working copy)
@@ -22,9 +22,9 @@

  import javax.servlet.http.HttpServletResponse;

+import org.apache.catalina.Session;
  import org.apache.catalina.connector.Request;
  import org.apache.catalina.deploy.LoginConfig;
-import org.apache.catalina.Session;

After applying this change locally, it passes the checkstyle rules as 
currently defined in the trunk and implemented by checkstyle version 5.5 
downloaded as a tomcat dependency.

Thanks,

Brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org