tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1214855 - in /tomcat/trunk: java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp
Date Fri, 16 Dec 2011 13:16:54 GMT
On 15/12/2011 23:22, markt@apache.org wrote:
> Konstantin Kolinko <knst.kolinko@gmail.com> wrote:
> 
>> 1. The test & fix is wrong. <\%  should print <%
>> 
>> 2. Note " // Output the first character" comment in 
>> parseTemplateText(). That is special handling of the first
>> character.
>> 
>> My understanding of the code before this change is that the loop in
>> parseTemplateText() always breaks when '<' is encountered.
>> 
>> I think that when that '<' is not start of a tag and similar, then 
>> parseTemplateText() is just called again. On this second call the
>> '<' will be the first character and that is why it is handled
>> specially before the  loop. (That is just from code review. I have
>> not tried to debug it yet).

<snip/>

> 
> Yep, brain not fully engaged when I made that change. I'll try and
> look at this again tomorrow. Feel free to revert my "fix" in the
> meantime.

Should be fixed properly now.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message