tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/catalina/loader/ test/webapp-3.0-virtual-webapp/ test/web...
Date Fri, 02 Dec 2011 21:25:49 GMT
On 02/12/2011 21:20, Mark Thomas wrote:
> On 02/12/2011 21:08, Mark Thomas wrote:
>> On 02/12/2011 20:49, slaurent@apache.org wrote:
>>> Author: slaurent
>>> Date: Fri Dec  2 20:49:50 2011
>>> New Revision: 1209686
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1209686&view=rev
>>> Log:
>>> bug 51741: Eclipse WTP "Serve modules without publishing" broken with
>>> tc7, needs patch in tomcat 
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=51741
>>
>> You need to run checkstyle on this. There are a number of issues including:
>> - files without license headers
>> - files with license headers that do not use the expected layout
>> - an import from o.a.catlina used within o.a.naming wich is not permitted
> 
> Just seen that this is unused which makes this an easy fix.

They were all easy and fixing the failures was just as easy as skipping
the checks. Patch applied to trunk.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message