tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1198553 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml webapps/docs/config/ajp.xml webapps/docs/config/http.xml
Date Thu, 17 Nov 2011 08:44:38 GMT
2011/11/17 Mark Thomas <markt@apache.org>:
> On 06/11/2011 20:52, kkolinko@apache.org wrote:
>> Author: kkolinko
>> Date: Sun Nov  6 20:52:33 2011
>> New Revision: 1198553
>>
>> URL: http://svn.apache.org/viewvc?rev=1198553&view=rev
>> Log:
>> Merged revisions r1197158, r1198552 from tomcat/trunk:
>> Add new attribute to AbstractEndpoint and use it to speed up Tomcat tests.
>> If the attribute "fastShutdown" is set on the endpoint,
>> the usual wait of 1 sec during pause() is skipped.
>
> Any thoughts welcome.
>

"fastShutdown" disables 1sec wait in AbstractEndpoint.pause(). The
idea behind it is that when test ends there are no open connections
being processed by Tomcat (and so there is not much benefit in pausing
endpoint before stopping it).

It may be that for some tests that is not true.

Before implementing it I pondered an idea of alternative
implementation to minimize wait in endpoint.pause(). The idea was to
iterate over endpoint threads and check whether pausing was successful
 (I think that will be faster than this empirical 1 second wait).
Though implementing that would require an insight in implementation of
a specific endpoint.

It should be possible to update TomcatBaseTest class to turn off this
feature for some tests, or for Apr connector as a whole.

That is just regarding this feature.


There might be other questions like whether Apr shutdown can be made
more robust and whether this crash is triggered by some other issue.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message