tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1200582 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Thu, 10 Nov 2011 23:08:15 GMT
2011/11/11  <rjung@apache.org>:
> Author: rjung
> Date: Thu Nov 10 21:46:32 2011
> New Revision: 1200582
>
> URL: http://svn.apache.org/viewvc?rev=1200582&view=rev
> Log:
> Add proposal.
>
> Modified:
>    tomcat/tc6.0.x/trunk/STATUS.txt
>
> +* Fix setting of some standard attributes on cluster managers.
> +  Backport of r1200555 from trunk.
> +  http://people.apache.org/~rjung/patches/tc6-cluster-fix-attribute-setting.patch
> +  +1: rjung
> +  -1:
> +

What about property change listeners and other side effects? Similar
previous changes in trunk:
http://svn.apache.org/viewvc?view=revision&revision=1175155

I think that the same setters are used when configuring the object
through Digester and there are no listeners in a newly created object.
So unlikely there are side effects.


Calling  setRandomFile() looks especially suspicious,
but anyway if it is never called it is called again at the top of
ManagerBase.getRandomBytes().

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message