tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Tagging 7.0.23
Date Tue, 01 Nov 2011 21:57:57 GMT
2011/11/1 Mark Thomas <markt@apache.org>:
> On 01/11/2011 14:16, Konstantin Kolinko wrote:
>>
>> 1) Re: http://svn.apache.org/viewvc?view=revision&revision=1195965
>
>> Is it possible to throw a runtime exception from parseParameters()
>> when the limit is reached instead of dropping the parameters, or you
>> think the API does not allow it?
>
> I don't think the API allows it. At least it may give users a nasty
> surprise.
>

Well, both surprises (either dropping or throwing) can be nasty. So,
what to choose...

Reviewing the API I see that getParts()/getPart() is consistent that
it rethrows the same exception if parsing failed once.

The getParameter()/getParameterValues()/getParameterNames() API does
not say about throwing an exception, and it raises a question whether
it shall be thrown the first time only or rethrown consistently.
Let's go on with dropping.

I think there might be an option, e.g. on a Context to rethrow
exception, or set a request attribute, if parameters parsing failed.
That can be deemed a different feature / itch. It may be extended to
cover some other cases, e.g. '&&' invalid chunk error, or parameters
dropped during urldecode.

2011/11/2 Mark Thomas <markt@apache.org>:
> On 01/11/2011 19:42, Mark Thomas wrote:
>> On 01/11/2011 14:16, Konstantin Kolinko wrote:
>>> 2) http://markmail.org/message/5k4urwimvvmeqees
>>
>> I'll see if I can get that fixed too.
>
> Hmm. The problem here is that the context.xml files are registered as
> resources that trigger reload rather than redeploy. As such, any changes
> to the context.xml files trigger a reload but do not have any affect
> since the Context object is not re-created.
>
> My current thinking is to add redeployResoucre and reloadResource to
> Context and deprecate watchedResource, making it a synonym for
> reloadResource. Thoughts? (I haven't tested this yet.)
>

Are you talking about API or about Configuration?

<WatchedResource> in conf/context.xml defaults to WEB-INF/web.xml.  It
is a news for me that it covers context.xml as well.

I think web.xml triggers reload, context.xml triggers redeploy.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message