tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1203253 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ test/org/apache/catalina/startup/ webapps/docs/config/
Date Fri, 18 Nov 2011 02:12:26 GMT
2011/11/17 Mark Thomas <markt@apache.org>:
> On 17/11/2011 16:40, markt@apache.org wrote:
>> Author: markt
>> Date: Thu Nov 17 16:40:02 2011
>> New Revision: 1203253
>>
>> URL: http://svn.apache.org/viewvc?rev=1203253&view=rev
>> Log:
>> Refactor acceptor pause and shutdown to remove need for 'random' waits in
>> the shutdown code.
>> Removes the need for the fastShutdown attribute
>
> I don't think this is quite as fast as it was with fastShutdown but
> we'll need to wait for the buildbot results to be sure.
>

In trunk:
Run      Revision     Time for testsuite run ("compile_1")
2529   1203078    18 mins, 6 secs
2530   1203091    18 mins, 37 secs
2531   1203253    17 mins, 33 secs  <- this change
2532   1203278    17 mins, 46 secs
2533   1203346    16 mins, 30 secs

It is good.

I cannot explain speedup in run 2533 rather than it being random or
good time of day. r1203346 removed of unused code in
XMLEncodingDetector, but it should not change that much. We will see
whether it stays with next runs. Anyway the numbers are good.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message