tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <kkoli...@apache.org>
Subject Re: svn commit: r1198640 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java
Date Mon, 07 Nov 2011 08:34:14 GMT
2011/11/7  <kkolinko@apache.org>:
> Author: kkolinko
> Date: Mon Nov  7 08:25:02 2011
> New Revision: 1198640
>
> URL: http://svn.apache.org/viewvc?rev=1198640&view=rev
> Log:
> Restore handleQueryParameters() call that was lost in r1189882
> This is not covered by our tests.
>
> Modified:
>    tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java
>
> --- tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java Mon Nov  7 08:25:02
2011
> @@ -116,8 +116,8 @@ public final class Parameters {
>         return Collections.enumeration(paramHashValues.keySet());
>     }
>
> -    // Shortcut.
>     public String getParameter(String name ) {
> +        handleQueryParameters();
>         ArrayList<String> values = paramHashValues.get(name);
>         if (values != null) {
>             if(values.size() == 0) {
>

Old implementation called getParameterValues() which called
handleQueryParameters().

What is odd is that there is above all this there is the following comment:
    // -------------------- Data access --------------------
    // Access to the current name/values, no side effect ( processing ).
    // You must explicitly call handleQueryParameters and the post methods.

Whatever needs handleQueryParameters() call there is not covered by
our testsuite.

I've already ported this commit to 7.0 - r1198641.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message