tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Tagging 7.0.23
Date Wed, 02 Nov 2011 00:08:58 GMT
2011/11/2 Mark Thomas <markt@apache.org>:
> On 01/11/2011 22:39, Mark Thomas wrote:
>> Changes to any context.xml have to trigger a redeploy else they won't
>> take effect as no new Context object will be created.
>
> My first stab at a patch for this is at [1]. Comments welcome.
>
> The one thing I don't like is that a change to conf/context.xml that
> breaks the file effectively kills the instance until the problem is
> fixed and the instance re-started.
>
> Mark
>
> http://people.apache.org/~markt/patches/2011-11-01-redeploy-trunk-v1.patch
>

Quick review - several typos:

mbeans-descriptors.xml:
- typo "findRedployResources"
- "Path to the resource, relative to docBase" - It is "either absolute
or relative to docBase".

docs: s/if is is updated/if it is updated/

At first view I was hesitant wrt to new syntax in conf/context.xml
(s/<WatchedResource>/<ReloadResource>/ but I am starting to like it.

Need to apply and play with it a while.


I do not see though how it is related to another/main topic of
http://markmail.org/message/5k4urwimvvmeqees
that is: if context.xml startup fails somehow the webapp continues
with the deploying the expanded dir.

I observed it during startup time, not during redeployment:

To reproduce, create conf/Catalina/localhost/host-manager.xml:

[[[
<?xml version="1.0" encoding="UTF-8"?>
<Context antiResourceLocking="false" privileged="true" >
 <Valve className="org.apache.catalina.valves.RemoteAddrValve"
        allow="(" />
</Context>
]]]

The logs below are from several days ago, before the multithreaded
deployment patch was applied. Note that "host-manager" is being
deployed twice.

(There seems to be NamingContextListener throwing exception from the
second deploy, but the app started successfully).

[[[ (...)
27.10.2011 16:29:04 org.apache.catalina.startup.Catalina load
INFO: Initialization processed in 1977 ms
27.10.2011 16:29:05 org.apache.catalina.core.StandardService startInternal
INFO: Starting service Catalina
27.10.2011 16:29:05 org.apache.catalina.core.StandardEngine startInternal
INFO: Starting Servlet Engine: Apache Tomcat/8.0.0-dev
27.10.2011 16:29:05 org.apache.catalina.startup.HostConfig deployDescriptor
INFO: Deploying configuration descriptor
(...)\build\conf\Catalina\localhost\host-manager.xml
27.10.2011 16:29:05 org.apache.tomcat.util.digester.SetPropertiesRule begin
WARNING: [SetPropertiesRule]{Context/Valve} Setting property 'allow'
to '(' did not find a matching property.
27.10.2011 16:29:05 org.apache.catalina.core.ContainerBase addChildInternal
SEVERE: ContainerBase.addChild: start:
org.apache.catalina.LifecycleException: Failed to start component
[StandardEngine[Catalina].StandardHost[localhost].StandardContext[/host-manager]]
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:152)
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:791)
	at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:766)
	at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:638)
	at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:608)
	at org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:533)
	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:446)
	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1303)
(...)
27.10.2011 16:29:07 org.apache.catalina.startup.HostConfig deployDirectory
INFO: Deploying web application directory (...)\build\webapps\host-manager
27.10.2011 16:29:07 org.apache.catalina.core.NamingContextListener
lifecycleEvent
SEVERE: Creation of the naming context failed:
javax.naming.NamingException: Context is read only
27.10.2011 16:29:07 org.apache.catalina.startup.HostConfig deployDirectory
INFO: Deploying web application directory (...)\build\webapps\manager
27.10.2011 16:29:07 org.apache.catalina.startup.HostConfig deployDirectory
INFO: Deploying web application directory (...)\build\webapps\ROOT
27.10.2011 16:29:07 org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler ["http-bio-8080"]
27.10.2011 16:29:07 org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler ["ajp-bio-8009"]
27.10.2011 16:29:07 org.apache.catalina.startup.Catalina start
INFO: Server startup in 2962 ms
]]]

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message