tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)
Date Sat, 05 Nov 2011 22:31:44 GMT
2011/11/6 Mark Thomas <markt@apache.org>:
>
> I'm in two minds whether to apply this patch before or after the 7.0.23
> tag. There are clearly issues here that need fixing but the patch is
> quite invasive. I'm leaning towards tagging after the patch is applied.
> Thoughts?
>

In short: I think there are two issues
a) what FailedContext solves
b) touching context.xml causing redeploy instead of reload

I think a) needs to be solved asap and likely to be backported.

b) can be postponed.

Regarding b) - remember that order of entries in redeploy list used by
autodeploy check is very important (because files ##(n+1)..last are
deleted if file #n is touched).  I am not yet sure that the patch is
safe adding context.xml there.

====================
Regarding RequestFilterValve:
It sounds like you have tested it with JMX.

If it throws LifecycleException from initInternal() are you able to
fix it with JMX later?

(Maybe "throw new LifecycleException" should be removed from
initInternal(), keeping in only in startInternal() ?  I do not mind to
keep the code as is now, but though maybe there is a reason to remove
the first throw).


Regarding RequestFilterValve (one more):

I thought that there could be a public method callable through JMX to
check whether allowed address is allowed or denied.
Something like "test(String)" or "isAllowed(String)".

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message