tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Truk <mt...@apache.org>
Subject Re: svn commit: r1196077 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Date Wed, 02 Nov 2011 08:33:02 GMT
On 11/01/2011 06:48 PM, Konstantin Kolinko wrote:
> 2011/11/1<mturk@apache.org>:
>
>> --- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
>> +++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Tue Nov  1 16:07:10 2011
>> @@ -2817,6 +2816,8 @@ static BOOL initialize_extension(void)
>>      if (read_registry_init_data()) {
>>          if (get_iis_info(&iis_info) != JK_TRUE) {
>>              jk_log(logger, JK_LOG_ERROR, "Could not retrieve IIS version from registry");
>> +        }
>> +        else {
>>              if (use_auth_notification_flags)
>>                  iis_info.filter_notify_event = SF_NOTIFY_AUTH_COMPLETE;
>>              else
>
> You not only axed the whitespace, but also added the above "else" into
> initialize_extension(void) method.
>

Right. This should have been a separate commit message,
but the committed implementation is correct.

If the IIS version cannot be read from registry, load must fail.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message