tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52009] NPE exception in org.apache.catalina.connector.CoyoteAdapter.service
Date Fri, 14 Oct 2011 15:03:08 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009

--- Comment #11 from Mark Thomas <markt@apache.org> 2011-10-14 15:03:08 UTC ---
(In reply to comment #9)
> > 5. If I put breakpoint on the request.recycle() call above, the call stack is:
> > 
> > CoyoteAdapter.event(Request, Response, SocketStatus) line: 252    
> > CoyoteAdapter.service(Request, Response) line: 411    
> > Http11NioProcessor(AbstractHttp11Processor<S>).process(SocketWrapper<S>)
line:
> > 970    
> > Http11NioProtocol$Http11ConnectionHandler(AbstractProtocol$AbstractConnectionHandler<S,P>).process(SocketWrapper<S>,
> > SocketStatus) line: 515    
> > NioEndpoint$SocketProcessor.run() line: 1550    
> > 
> > After returning from event() call on CoyoteAdapter:411 (the call returns false)
> > the lines 431..440 are executed:
> >             } else if (!comet) {
> >                 request.finishRequest();
> >                 response.finishResponse();
> >                 if (postParseSuccess) {
> >                     // Log only if processing was invoked.
> >                     // If postParseRequest() failed, it has already logged it.
> >                     ((Context) request.getMappingData().context).logAccess(
> >                             request, response,
> >                             System.currentTimeMillis() - req.getStartTime(),
> >                             false);
> >                 }
> > 
> > The comet variable is false and postParseSuccess is true.
> > The request is already recycled and request.getMappingData().context is null,
> > leading to an NPE.
> 
> The above is a legitimate bug. Recycling in event() -> returning to service()
> -> NPE when trying to log it.

Sorry. Missed that. I'll take a look.

(In reply to comment #10)
> Hi, Mark:
> 
> Sorry to add you to the cc list without notification in advance. I tried to
> send email to markt@apache.org, but rejected, and you are the NIO connector
> code owner, so i did it. Thanks for your understanding.

1. I am not the maintainer of the NIO code. All of the committers work on all
of the code base. There are no project or component leads at the ASF.

2. Sending private mails to individual committers is also frowned upon and most
committers (me included) reject or ignore them. The only place to discuss
change to the Tomcat code base is the dev@tomcat.a.o mailing list.

>  This application can work on tomcat 6.0.19, but failed in trunk and 7.0.9/22,
> so i think it's tomcat nio connector problem. If i don't add NIO connector to
> server.xml, there is no exception.

See above.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message