tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51953] Proposal: netmask filtering valve and filter
Date Fri, 14 Oct 2011 23:03:25 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953

Francis Galiegue <fgaliegue@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27691|0                           |1
        is obsolete|                            |
  Attachment #27726|0                           |1
        is obsolete|                            |

--- Comment #18 from Francis Galiegue <fgaliegue@gmail.com> 2011-10-14 23:03:25 UTC
---
Created attachment 27782
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27782
Version "0.1" of the patch

Full patch over Apache's tomcat70 git repo (therefore over tomcat's trunk if I
get it right).

This patch addresses the following remarks raised on the devel mailing list:

* .get*() now return a suitable input for .set*();
* as the process of filling lists for deny and allow is the same, for the
filter and the valve, factorize it;
* more comments in NetMask;
* coding style issues;
* javadoc;
* throw IllegalArgumentException from the Valve and Filter if a wrongly
formatted NetMask is passed in.

Now, I have a problem which I cannot understand, wrt error handling...

I use the base tar.gz as built by "ant release", in
output/release/v8.0.0-dev/bin/apache-tomcat-8.0.0-dev.tar.gz. I unarchive in a
directory, do startup.sh, it starts.

I then edit the web.xml so as to apply the RemoteCIDRFilter: Tomcat reloads the
webapp, the filter applies. Then I edit web.xml so as to apply an ILLEGAL
netmask: even though the base NetMask tests work (constructor refuses the
input), when reloading the webapp, it seems that nothing is even LOGGED (I do
log errors about bad netmasks) and the previous filter stays in place :/

What am I doing wrong? I have a list of TODOs but don't even want to mention
that list before I understand what the problem is with the filter. Note: I have
not debugged yet... I use IDEA, so if someone knows how to debug that I'd be
happy.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message