tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method
Date Wed, 19 Oct 2011 18:02:15 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940

--- Comment #10 from Mark Thomas <markt@apache.org> 2011-10-19 18:02:15 UTC ---
(In reply to comment #9)
> 1. I tried to test this in trunk, and replaying a POST request fails for me.

That is a side-effect of r987955 which is not directly related to this bug.

> 2. request.getCoyoteRequest().method().setString("GET");
> is seen as GET in access log.  Not much of an issue though, as anyway we return
> not what was originally requested by client.
> 
> I think that to fix this one can restore the original method in
> FormAuthenticator#forwardToLoginPage(..) when disp.forward() call returns.

That would work. I'm on the fence. We can record what was requested or what we
process.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message