tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50860] In case of invalid or empty slqQuery connection are always invalidated without usefull information
Date Wed, 19 Oct 2011 16:57:10 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50860

--- Comment #1 from Alexander Pogrebnyak <alex-pub.apache-ant@reflexion.net> 2011-10-19
16:57:10 UTC ---
Although it seems similar to Bug 50660, the case of a `null` query is really a
misconfiguration error.

I think it should be treated differently from "invalid" SQL case and in case of
`null` query throw RuntimeException that tells the user about misconfiguration.

I also think that obvious configuration validation (validationQuery is null or
empty, when validation is enabled ) has to happen when the connection is
initialized (or better yet in ConnectionPool.init), because in my test it would
not happen before the validationInterval would have expired, and a one-off
message in the middle of log stream does not call to much attention.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message