tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow
Date Thu, 13 Oct 2011 11:32:13 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264

--- Comment #19 from Konstantin Kolinko <knst.kolinko@gmail.com> 2011-10-13 11:32:13
UTC ---
(In reply to comment #18)
> Created attachment 27767 [details]

Re: startStopExecutor.allowCoreThreadTimeOut(true);

I think that just using "0" instead of getStartStopThreadsInternal() as the
value of first argument (corePoolSize) in ThreadPoolExecutor constructor will
have the same effect. It is not much of a difference though.

Re: Iterator<Future<Void>> iter = results.iterator();

It could be rewritten as for(Future<Void> future: results) loop.
In one place Future<?> is used, while I think it could be Future<Void> like in
other places.

Re: HostConfig

I do not quite understand why to remove
"if (deploymentExists(cn.getName())) { return; }"
from the beginning of e.g. deployDescriptor() method.

The HostConfig#deployApps() method is called every 10 seconds to perform
autodeployment (by HostConfig#check() called by HostConfig#lifecycleEvent())
and without early return it will proceed to parsing context.xml file.

Renaming s/dir/war/ can be done now, to slightly reduce future patch.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message