tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francis Galiegue <fgalie...@gmail.com>
Subject Re: [RFC] Netmask-based filter and valve
Date Tue, 11 Oct 2011 11:54:58 GMT
On Tue, Oct 11, 2011 at 11:41, Konstantin Kolinko
<knst.kolinko@gmail.com> wrote:
> 2011/10/10 Francis Galiegue <fgaliegue@gmail.com>:
>> error handling (what
>> should be done when an illegal netmask is supplied, etc).
>
> I think the called method should fail with some RuntimeException.
>
> That is what will happen with existing RemoteAddrValve if you pass a
> value that Pattern.compile() cannot handle. (See
> RequestFilterValve#setAllow(String)).
>
> It would not be safe to operate a Valve that is misconfigured.
>

OK, I will update the code, post an updated version in the Bugzilla
entry and add more questions over there (#51953).

-- 
Francis Galiegue, fgaliegue@gmail.com
"It seems obvious [...] that at least some 'business intelligence'
tools invest so much intelligence on the business side that they have
nothing left for generating SQL queries" (St├ęphane Faroult, in "The
Art of SQL", ISBN 0-596-00894-5)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message