tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keiichi Fujino <kfuj...@apache.org>
Subject Re: svn commit: r1186631 - /tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Date Fri, 21 Oct 2011 01:17:11 GMT
2011/10/21 Mark Thomas <markt@apache.org>:
> On 20/10/2011 08:00, kfujino@apache.org wrote:
>> Author: kfujino
>> Date: Thu Oct 20 07:00:57 2011
>> New Revision: 1186631
>>
>> URL: http://svn.apache.org/viewvc?rev=1186631&view=rev
>> Log:
>> Avoid an unnecessary session ID change notice.
>
> Given this...
>> Notice of changed session ID by JvmRouteBinderValve is unnecessary to BackupManager.
>
>> +        if (c != null && getManager(request) instanceof DeltaManager)
{
>
> Might this be better to account for custom Manager implementations?
>
> if (c != null && !(getManager(request) instanceof BackupManager)) {
>
>
> Mark

Thanks for the review.
I committed on r1187149.


-- 
Keiichi.Fujino

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message