tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Unit tests for Tomcat 6
Date Mon, 17 Oct 2011 12:50:29 GMT
Hi!

It would be nice to backport unit tests from Tomcat 7 to Tomcat 6.

Just some thoughts.

1. As far as I remember one of changes that allowed to create the
Tomcat class and unit tests for Tomcat 7 was getting rid of
org.apache.catalina.ServerFactory class that holds singleton reference
to a Server instance.

E.g. one of those changes:
http://svn.apache.org/viewvc?view=revision&revision=772142

My old thought about that singleton was that it could be circumwented
if the test case created its own classloader like Bootstrap does it.
Now I think that it can be solved more easily: Add #clear() method to
ServerFactory class that would clear the singleton reference
and call ServerFactory.clear() either during teardown of a test or at startup.


2. It would be nice to have CTR for the test subdirectory in tc6.0.x.

An alternative could be to create a branch in tc6.0.x/branches or in
sandbox  and vote&merge from there.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message