tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Removing whitespace from *.xsd and *.dtd files
Date Sat, 22 Oct 2011 22:54:32 GMT
On 22/10/2011 23:33, Konstantin Kolinko wrote:
> 2011/10/23 Mark Thomas <markt@apache.org>:
>> On 22/10/2011 22:54, Konstantin Kolinko wrote:
>>> Hi!
>>>
>>> http://svn.apache.org/viewvc?rev=1187778&view=rev
>>> affected a number of *.xsd and *.dtd files.
>>>
>>> I think we should not touch those without a good reason.

<snip/>

>> I don't see the harm in removing the trailing white-space from these
>> files. It shouldn't change their meaning.
> 
> From technical point of view it should not. But all of them originate
> from somewhere, and I would not want them to differ from their
> originals more than necessary.

That is a fair point.

My own preference is for not having to list them as exclusions in the
checkstyle config. Thinking about it, I'm not sure how easy that would
be. It is easy enough to filter by file extension but that doesn't quite
work in this case. I'd rather not have a separate checkstyle file just
for trailing white-space but I don't see another way to exclude the spec
files.

Given that diff tools can be easily configured to ignore white-space I'm
leaning towards leaving things as they currently are.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message