tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Removing whitespace from *.xsd and *.dtd files
Date Sat, 22 Oct 2011 22:13:35 GMT
On 22/10/2011 22:54, Konstantin Kolinko wrote:
> Hi!
> 
> http://svn.apache.org/viewvc?rev=1187778&view=rev
> affected a number of *.xsd and *.dtd files.
> 
> I think we should not touch those without a good reason.
> 
>    tomcat/trunk/java/javax/servlet/jsp/resources/jsp_2_1.xsd
>    tomcat/trunk/java/javax/servlet/jsp/resources/jsp_2_2.xsd
>    tomcat/trunk/java/javax/servlet/jsp/resources/jspxml.dtd
>    tomcat/trunk/java/javax/servlet/jsp/resources/jspxml.xsd
>    tomcat/trunk/java/javax/servlet/jsp/resources/web-jsptaglibrary_2_1.xsd
> 
>    tomcat/trunk/java/javax/servlet/resources/XMLSchema.dtd
>    tomcat/trunk/java/javax/servlet/resources/datatypes.dtd
>    tomcat/trunk/java/javax/servlet/resources/javaee_6.xsd
>    tomcat/trunk/java/javax/servlet/resources/javaee_web_services_1_3.xsd
>    tomcat/trunk/java/javax/servlet/resources/javaee_web_services_client_1_3.xsd
>    tomcat/trunk/java/javax/servlet/resources/web-app_2_2.dtd
>    tomcat/trunk/java/javax/servlet/resources/web-app_2_5.xsd
>    tomcat/trunk/java/javax/servlet/resources/web-app_3_0.xsd
>    tomcat/trunk/java/javax/servlet/resources/web-common_3_0.xsd
>    tomcat/trunk/java/javax/servlet/resources/web-fragment_3_0.xsd
>    tomcat/trunk/java/javax/servlet/resources/xml.xsd

I don't see the harm in removing the trailing white-space from these
files. It shouldn't change their meaning.

> Other interesting note is that this commit removed some trailing
> whitespace from values in *.properties files.
> 
> Generally, this change might be visible to users, as trailing
> whitespace is preserved when reading properties. Though those that I
> noticed thus far look more like an editor's error - backported to tc7
> in r1187816. More is likely to follow.

Given that trailing white-space is extremely hard to see in .properties
files, I doubt that any of it was deliberate. I certainly can't recall
an instance where trailing white-space necessary.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message