Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 163777DC4 for ; Wed, 21 Sep 2011 02:12:57 +0000 (UTC) Received: (qmail 9025 invoked by uid 500); 21 Sep 2011 02:12:56 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 8955 invoked by uid 500); 21 Sep 2011 02:12:56 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 8946 invoked by uid 99); 21 Sep 2011 02:12:56 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Sep 2011 02:12:56 +0000 Received: from localhost (HELO mail-wy0-f173.google.com) (127.0.0.1) (smtp-auth username kfujino, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Sep 2011 02:12:56 +0000 Received: by wyh22 with SMTP id 22so1280767wyh.4 for ; Tue, 20 Sep 2011 19:12:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.137.232 with SMTP id y82mr1534323wei.104.1316571174317; Tue, 20 Sep 2011 19:12:54 -0700 (PDT) Received: by 10.216.85.194 with HTTP; Tue, 20 Sep 2011 19:12:54 -0700 (PDT) In-Reply-To: <4E787B23.9090405@kippdata.de> References: <20110918092125.310D823888E4@eris.apache.org> <4E787B23.9090405@kippdata.de> Date: Wed, 21 Sep 2011 11:12:54 +0900 Message-ID: Subject: Re: svn commit: r1172234 - in /tomcat/trunk/java/org/apache/catalina/ha/session: ClusterManagerBase.java DeltaSession.java From: Keiichi Fujino To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 2011/9/20 Rainer Jung : > > Thanks for the review. > > I refactored trunk a bit to move some of the common clone code to the > base class. If you like it I will backport to TC 7. Please comment on > r1173088 and r1173090. > > Regards, > > Rainer > That looks nice except for the following. I added two fixes. maxActiveSessions is removed from BackupManager#cloneFromTemplate. The copy of maxActiveSessions is already done by ClusterManagerBase#clone. For creating the instance of sessionAttributePattern, we have to call setter of sessionAttributeFilter. I committed them on r1173461. Please check it. -- Keiichi.Fujino --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org