Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.212.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20110907181121.4958F2388B9B@eris.apache.org>
References: <20110907181121.4958F2388B9B@eris.apache.org>
Date: Wed, 7 Sep 2011 22:49:08 +0400
Message-ID: 
 <CABzHfV=O3_Xuu4h7DrfaN+O5EDKnCqwSxt9b4Api-3bV6Z1D6w@mail.gmail.com>
Subject: Re: svn commit: r1166290 -
 /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2011/9/7  <markt@apache.org>:
> Author: markt
> Date: Wed Sep =A07 18:11:20 2011
> New Revision: 1166290
>
> URL: http://svn.apache.org/viewvc?rev=3D1166290&view=3Drev
> Log:
> Add a simple annotation cache to improve performance for applications tha=
t use lots of non-poolable tags.

1. I think most classes do not have annotations. If I understand
correctly the code allocates new ArrayList() for each class. Maybe we
can optimize for classes that do not have annotations?
(E.g. using a shared instance of Collections.emptyList()).

2. I wonder when the cache is cleared. E.g. if we are in development
mode or have enabled unloading unused JSPs in JspServlet
configuration. If I understand correctly it accumulates references to
Class objects but never releases them.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org