tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1174289 - in /tomcat/jk/trunk: native/apache-1.3/ native/apache-2.0/ native/common/ native/iis/ xdocs/miscellaneous/ xdocs/reference/
Date Thu, 22 Sep 2011 18:33:17 GMT
2011/9/22  <rjung@apache.org>:
> Author: rjung
> Date: Thu Sep 22 18:01:31 2011
> New Revision: 1174289
>
> URL: http://svn.apache.org/viewvc?rev=1174289&view=rev
> Log:
> - URI Map: Add "sticky_ignore" extension attributes to uri worker map.
>  It allows to disable stickyness for individual mounts.
>
> - HTTPD: Allow dynamic disabling of stickyness using the environment
>  variable JK_STICKY_IGNORE. This can be useful to break cookie stickyness
>  for non-sticky requests like login forms.
>
> Modified:
>    tomcat/jk/trunk/native/apache-1.3/mod_jk.c
>    tomcat/jk/trunk/native/apache-2.0/mod_jk.c
>    tomcat/jk/trunk/native/common/jk_lb_worker.c
>    tomcat/jk/trunk/native/common/jk_service.h
>    tomcat/jk/trunk/native/common/jk_status.c
>    tomcat/jk/trunk/native/common/jk_uri_worker_map.c
>    tomcat/jk/trunk/native/common/jk_uri_worker_map.h
>    tomcat/jk/trunk/native/common/jk_util.c
>    tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
>    tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
>    tomcat/jk/trunk/xdocs/reference/apache.xml
>    tomcat/jk/trunk/xdocs/reference/uriworkermap.xml
>    tomcat/jk/trunk/xdocs/reference/workers.xml
>
> Modified: tomcat/jk/trunk/native/apache-1.3/mod_jk.c
> URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-1.3/mod_jk.c?rev=1174289&r1=1174288&r2=1174289&view=diff
>
==============================================================================
(...)
> +    sticky_ignore = ap_table_get(r->subprocess_env, JK_ENV_STICKY_IGNORE);
> +    if (sticky_ignore) {
> +        if (*sticky_ignore == '\0') {
> +            s->extension.reply_timeout = JK_TRUE;

You are assigning to a wrong option!
Below and in httpd 2.0 version as well.

Also the above means that if the variable is present, but has empty
value, it is threated as true? This flag is false by default
elsewhere.

> +        }
> +        else {
> +            int r = atoi(sticky_ignore);
> +            if (r) {
> +                s->extension.reply_timeout = JK_TRUE;
> +            }
> +            else {
> +                s->extension.reply_timeout = JK_FALSE;
> +            }
> +        }
> +    }
> +
>     if (conf->options & JK_OPT_DISABLEREUSE)
>         s->disable_reuse = 1;

>
>
> Modified: tomcat/jk/trunk/native/apache-2.0/mod_jk.c
> URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/apache-2.0/mod_jk.c?rev=1174289&r1=1174288&r2=1174289&view=diff
>
==============================================================================
> --- tomcat/jk/trunk/native/apache-2.0/mod_jk.c (original)
> +++ tomcat/jk/trunk/native/apache-2.0/mod_jk.c Thu Sep 22 18:01:31 2011
(...)
> @@ -798,6 +801,22 @@ static int init_ws_service(apache_privat
>             s->extension.reply_timeout = r;
>     }
>
> +    sticky_ignore = apr_table_get(r->subprocess_env, JK_ENV_STICKY_IGNORE);
> +    if (sticky_ignore) {
> +        if (*sticky_ignore == '\0') {
> +            s->extension.reply_timeout = JK_TRUE;

Here as well.

> +        }
> +        else {
> +            int r = atoi(sticky_ignore);
> +            if (r) {
> +                s->extension.reply_timeout = JK_TRUE;
> +            }
> +            else {
> +                s->extension.reply_timeout = JK_FALSE;
> +            }
> +        }
> +    }
> +
>     if (conf->options & JK_OPT_DISABLEREUSE)
>         s->disable_reuse = 1;
>
>

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message