tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1173082 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java test/org/apache/catalina/comet/TestCometProcessor.java
Date Tue, 20 Sep 2011 12:41:57 GMT
2011/9/20 Mark Thomas <markt@apache.org>:
> On 20/09/2011 12:09, Konstantin Kolinko wrote:
>> 2011/9/20  <markt@apache.org>:
>>> Author: markt
>>> Date: Tue Sep 20 11:02:41 2011
>>> New Revision: 1173082
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1173082&view=rev
>>> Log:
>>> Remove empty comment
>>
>> You did more than removed a comment (you've committed two files
>> instead of one)...
>
> Thanks. I'll revert that now. If it isn't obvious, I'm working on fixing
> the JUnit test failures.
>

I see that, but it looks more like a temporary debug code.

BTW: I am unable to reproduce Gump failure for TestCometProcessor with NIO
(running with JDK 6u26/WinXP),
but this test fails for me when running it with APR connector.

trunk, @r1173101

[[[
    [junit] INFO: Stopping ProtocolHandler ["http-apr-8002"]
    [junit] 20.09.2011 16:36:49 org.apache.coyote.AbstractProtocol destroy
    [junit] INFO: Destroying ProtocolHandler ["http-apr-8002"]
    [junit] 20.09.2011 16:36:49
org.apache.catalina.connector.CoyoteAdapter event
    [junit] SEVERE: null
    [junit] java.lang.NullPointerException
    [junit] 	at
org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:211)
    [junit] 	at
org.apache.coyote.http11.Http11AprProcessor.event(Http11AprProcessor.java:133)
    [junit] 	at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:513)
    [junit] 	at
org.apache.tomcat.util.net.AprEndpoint$SocketEventProcessor.run(AprEndpoint.java:1869)
    [junit] 	at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    [junit] 	at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    [junit] 	at java.lang.Thread.run(Thread.java:662)
    [junit] 20.09.2011 16:36:50
org.apache.catalina.core.StandardService stopInternal
    [junit] INFO: Stopping service Tomcat
]]]

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message