tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1157810 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContextValve.java java/org/apache/catalina/core/StandardHostValve.java test/org/apache/catalina/core/TestStandardContextValve.java
Date Thu, 01 Sep 2011 18:05:51 GMT
2011/9/1 Mark Thomas <markt@apache.org>:
> On 15/08/2011 13:29, markt@apache.org wrote:
>> Author: markt
>> Date: Mon Aug 15 12:29:58 2011
>> New Revision: 1157810
>>
>> URL: http://svn.apache.org/viewvc?rev=1157810&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51653
>> Move custom error handling from Host to Context.
>
> This was a bad idea. The authenticators are processed before the
> StandardContextValve so this broke custom error pages for 401s etc.
>
> I'll take another look at this. My current thinking is that firing
> request listeners should move to the Host with the error handling but I
> need to see what that looks like.
>

I think you have seen this as well:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51550#c9
though I do not know whether custom error handling can work for the
situation in BZ 51550. (I think it can't)

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message