tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r1174181 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xm
Date Sat, 24 Sep 2011 11:30:07 GMT
On 23.09.2011 23:57, Konstantin Kolinko wrote:
> Reviewing Eclipse warnings I noticed a bug in this commit.

Argh.

>> +    protected void clone(ClusterManagerBase copy) {
>> +        copy.name = "Clone-from-" + getName();
> 
> The above assignment is wrong.
> It assigns to ManagerBase.name which is a static field.
> (Why that field exists and why it is not final is another question).

... which I'mnot going to answer ...

> The old code was assigning the value to BackupManager.name, which is
> an instance field.

OK, I used the setter instead now.

> In Eclipse the warning was:
> The static field ManagerBase.name should be accessed in a static way	
> 
> Also there are several missing @Override annotations in the new methods.

Fixed also, ported to TC 7, updated TC 6 patch for Override, kept your
vote in STATUS.txt.

Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message