tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r1172234 - in /tomcat/trunk/java/org/apache/catalina/ha/session: ClusterManagerBase.java DeltaSession.java
Date Thu, 22 Sep 2011 14:52:01 GMT
On 21.09.2011 04:12, Keiichi Fujino wrote:
> 2011/9/20 Rainer Jung <rainer.jung@kippdata.de>:
>>
>> Thanks for the review.
>>
>> I refactored trunk a bit to move some of the common clone code to the
>> base class. If you like it I will backport to TC 7. Please comment on
>> r1173088 and r1173090.
>>
>> Regards,
>>
>> Rainer
>>
> 
> That looks nice except for the following.
> 
> I added two fixes.
> 
> maxActiveSessions is removed from BackupManager#cloneFromTemplate.
> The copy of maxActiveSessions is already done by ClusterManagerBase#clone.
> 
> For creating the instance of sessionAttributePattern, we have to call
> setter of sessionAttributeFilter.
> 
> I committed them on r1173461.
> Please check it.

Good, thanks. Will backport to tc7 and update tc6 proposal.

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message