tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Session.getLastAccessTime() ticking
Date Wed, 21 Sep 2011 19:15:14 GMT
On 21/09/2011 19:06, Konstantin Kolinko wrote:

<snip/>
> The first question that I have is that I do not see how last access is
> ticked if there is no explicit request for a session. I think it
> should be ticked regardless of whether getSession(..) has been called.

StandardHostValve look for ACCESS_SESSION.

> 2. Access time in StandardSession is updated using System.currentTimeMillis();
> 
> The second question that I have is that it contradicts my "b)" point
> from above. I think it is against the spec.

On the surface, that looks like a reasonable thing to do but the session
doesn't have access to the request so the change could be quite invasive.

> The third question is that there are a lot of places that call
> access(), and every such call updates thisAccessedTime in
> StandardSession.
> It looks like not all such calls are associated with an actual
> request, and strictly speaking they should not update the time.

Fair point, but see above.

Rainer went through all of this some time ago and I thought that he
brought everything in line with the spec so I am surprised there are so
many apparent differences. I'd be interested in his views.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message