tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1166712 - in /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test: AbandonPercentageTest.java AlternateUsernameTest.java Async0IdleTestBug50477.java BorrowWaitTest.java
Date Thu, 08 Sep 2011 14:32:09 GMT
Author: markt
Date: Thu Sep  8 14:32:08 2011
New Revision: 1166712

URL: http://svn.apache.org/viewvc?rev=1166712&view=rev
Log:
Fix Eclipse warnings

Modified:
    tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
    tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AlternateUsernameTest.java
    tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
    tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/BorrowWaitTest.java

Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java?rev=1166712&r1=1166711&r2=1166712&view=diff
==============================================================================
--- tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
(original)
+++ tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AbandonPercentageTest.java
Thu Sep  8 14:32:08 2011
@@ -108,7 +108,7 @@ public class AbandonPercentageTest exten
         assertEquals("Number of connections active/busy should be "+con.length,con.length,datasource.getPool().getActive());
         this.datasource.getPoolProperties().setRemoveAbandonedTimeout(1);
         Thread.sleep(2500);
-        this.assertTrue("Number of connections should be less than 50.", (datasource.getPool().getActive()<50));
+        assertTrue("Number of connections should be less than 50.", (datasource.getPool().getActive()<50));
         this.datasource.getPoolProperties().setAbandonWhenPercentageFull(0);
         Thread.sleep(2500);
         assertEquals("Number of connections active/busy should be "+0,0,datasource.getPool().getActive());

Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AlternateUsernameTest.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AlternateUsernameTest.java?rev=1166712&r1=1166711&r2=1166712&view=diff
==============================================================================
--- tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AlternateUsernameTest.java
(original)
+++ tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/AlternateUsernameTest.java
Thu Sep  8 14:32:08 2011
@@ -106,6 +106,7 @@ public class AlternateUsernameTest exten
             useuser = user!=null;
         }
         
+        @Override
         public TestResult call() {
             TestResult test = new TestResult();
             PooledConnection pcon = null;

Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java?rev=1166712&r1=1166711&r2=1166712&view=diff
==============================================================================
--- tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
(original)
+++ tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
Thu Sep  8 14:32:08 2011
@@ -40,7 +40,7 @@ public class Async0IdleTestBug50477 exte
         this.datasource.getPoolProperties().setInitialSize(0);
         try {
             Future<Connection> cf = ((DataSourceProxy)datasource).getConnectionAsync();
-            Connection con  = cf.get(5, TimeUnit.SECONDS);
+            cf.get(5, TimeUnit.SECONDS);
         }finally {
             tearDown();
         }

Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/BorrowWaitTest.java?rev=1166712&r1=1166711&r2=1166712&view=diff
==============================================================================
--- tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
(original)
+++ tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/BorrowWaitTest.java
Thu Sep  8 14:32:08 2011
@@ -49,6 +49,7 @@ public class BorrowWaitTest extends Defa
             System.err.println("testWaitTimeInfinite() test is disabled.");
             return;//this would lock up the test suite
         }
+        /*
         int wait = -1;
         this.init();
         this.datasource.setMaxActive(1);
@@ -64,6 +65,7 @@ public class BorrowWaitTest extends Defa
             assertTrue("Connection should have been acquired within +/- 1 second.",true);
         }
         con.close();
+        */
     }
 
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message