Return-Path: 
 <dev-return-119181-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org>
X-Original-To: apmail-tomcat-dev-archive@www.apache.org
Delivered-To: apmail-tomcat-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8B1CF817E
	for <apmail-tomcat-dev-archive@www.apache.org>;
 Thu, 25 Aug 2011 00:15:17 +0000 (UTC)
Received: (qmail 769 invoked by uid 500); 25 Aug 2011 00:15:16 -0000
Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org
Received: (qmail 485 invoked by uid 500); 25 Aug 2011 00:15:15 -0000
Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@tomcat.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@tomcat.apache.org>
List-Post: <mailto:dev@tomcat.apache.org>
List-Id: <dev.tomcat.apache.org>
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Delivered-To: mailing list dev@tomcat.apache.org
Received: (qmail 476 invoked by uid 99); 25 Aug 2011 00:15:15 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2011 00:15:15 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.212.45 as permitted sender)
Received: from [209.85.212.45] (HELO mail-vw0-f45.google.com) (209.85.212.45)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2011 00:15:07 +0000
Received: by vws17 with SMTP id 17so2061014vws.18
        for <dev@tomcat.apache.org>; Wed, 24 Aug 2011 17:14:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        bh=6yiO7tks9DrZ+ZS1kXBGKk9AwwHxBbkqh4hpp8Z5ns4=;
        b=P56zt0uBHSkm/oa/WvF/xgUX3aBiNe3mfGdoquxlMJdSuN60fY5ej7Pw/D2xKuZYhf
         Ib4nKiiEH18oKdgQaoxGuRdYCO0stzvhryiKZ3/7kxZbU/fi4drGDYGGuuSDtlz1VIJi
         a5AjmacRAJPb9+KFtySXOEdo0L28CX9yExoe0=
MIME-Version: 1.0
Received: by 10.52.185.2 with SMTP id ey2mr5714300vdc.369.1314231286970; Wed,
 24 Aug 2011 17:14:46 -0700 (PDT)
Received: by 10.52.185.106 with HTTP; Wed, 24 Aug 2011 17:14:46 -0700 (PDT)
In-Reply-To: <4E558F8D.8000603@apache.org>
References: <20110824234651.5661D238888F@eris.apache.org>
	<4E558F8D.8000603@apache.org>
Date: Thu, 25 Aug 2011 04:14:46 +0400
Message-ID: 
 <CABzHfVmWMNyQ1pquZrvYAZTK=BA1QJk9EoNbBFM4-2nu7jr+nw@mail.gmail.com>
Subject: Re: svn commit: r1161322 - in
 /tomcat/trunk/java/org/apache/catalina/connector:
 Connector.java LocalStrings.properties
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Checked: Checked by ClamAV on apache.org

2011/8/25 Mark Thomas <markt@apache.org>:
> On 25/08/2011 00:46, kkolinko@apache.org wrote:
>> Author: kkolinko
>> Date: Wed Aug 24 23:46:50 2011
>> New Revision: 1161322
>>
>> URL: http://svn.apache.org/viewvc?rev=3D1161322&view=3Drev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=3D51713
>> Improve message that is logged if there is a typo in the value of protoc=
ol in a <Connector> element.
>>
>> Modified:
>> =A0 =A0 tomcat/trunk/java/org/apache/catalina/connector/Connector.java
>> =A0 =A0 tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.pro=
perties
>>
>> Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/=
connector/Connector.java?rev=3D1161322&r1=3D1161321&r2=3D1161322&view=3Ddif=
f
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (orig=
inal)
>> +++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Wed A=
ug 24 23:46:50 2011
>> @@ -74,9 +74,8 @@ public class Connector extends Lifecycle
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0Class<?> clazz =3D Class.forName(protocolHand=
lerClassName);
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0this.protocolHandler =3D (ProtocolHandler) cl=
azz.newInstance();
>> =A0 =A0 =A0 =A0 =A0} catch (Exception e) {
>> - =A0 =A0 =A0 =A0 =A0 =A0log.error
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(sm.getString
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ("coyoteConnector.protocolHandlerInsta=
ntiationFailed", e));
>> + =A0 =A0 =A0 =A0 =A0 =A0log.error(sm.getString(
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"coyoteConnector.protocolHandle=
rInstantiationFailed", e), e);
>
> Is there any benefit to including the exception in the message as well
> as the log output? I would have thought:
> log.error(sm.getString(
> =A0 =A0 =A0 =A0"coyoteConnector.protocolHandlerInstantiationFailed"), e);
>
> would be sufficient.
>

A little. The non-English messages here already have "{0}", so I was
choosing between adding it here and removing it from them.

I'll update the fix.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org