tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51713] Bad Connector protocol causes NullPointerException when using Executor
Date Wed, 24 Aug 2011 16:00:21 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51713

--- Comment #2 from Christopher Schultz <chris@christopherschultz.net> 2011-08-24 16:00:21
UTC ---
It also appears that there is an incorrect parens situation going-in in
Connector(String):

    public Connector(String protocol) {
        setProtocol(protocol);
        // Instantiate protocol handler
        try {
            Class<?> clazz = Class.forName(protocolHandlerClassName);
            this.protocolHandler = (ProtocolHandler) clazz.newInstance();
        } catch (Exception e) {
            log.error
                (sm.getString
                 ("coyoteConnector.protocolHandlerInstantiationFailed", e));
        }
    }

I believe the intent was to log the error message and the exception, not to use
the exception as a parameter to sm.getString(). This is masking quite a bit of
the underlying error.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message