tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Date Fri, 26 Aug 2011 22:19:21 GMT
Thank you!
On 8/26/2011 7:31 AM, Konstantin Kolinko wrote:
> 2011/8/25 Konstantin Kolinko<knst.kolinko@gmail.com>:
>>> URL: http://svn.apache.org/viewvc?rev=1157874&view=rev
>>> Log:
>>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51583
>> 1) I think that because of this change the " while (con != null) {"
>> loop may run infinitely, because when pool.size() is 0 the con
>> variable is never set to null. You'll repeatedly release the same
>> connection.
>>
>> 2) Note that this change is in changelog for 7.0.21, but actually it
>> is not in TC7, because svn:externals property on tc7.0.x/trunk/modules
>> has not been updated.
> I fixed the loop and updated externals in TC7.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message