tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1160246 - /tomcat/tc5.5.x/trunk/STATUS.txt
Date Mon, 22 Aug 2011 12:56:04 GMT
Author: markt
Date: Mon Aug 22 12:56:04 2011
New Revision: 1160246

URL: http://svn.apache.org/viewvc?rev=1160246&view=rev
Log:
Update patch proposal

Modified:
    tomcat/tc5.5.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1160246&r1=1160245&r2=1160246&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Aug 22 12:56:04 2011
@@ -69,14 +69,24 @@ PATCHES PROPOSED TO BACKPORT:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51550
   Display error page rather than an empty response for an IllegalStateException
-  https://issues.apache.org/bugzilla/attachment.cgi?id=27317
+  https://issues.apache.org/bugzilla/attachment.cgi?id=27318
   +1: markt
   -0: kkolinko: I do not like removing the catch from CoyoteAdapter. It
       looks safer the old way. JkCoyoteHandler does not handle Errors, just
       Exceptions. It seems from the patch that all you need to fix this bug is
         ep.setStatus(MsgContext.JK_STATUS_ERROR);
       Can't it be done by CoyoteAdapter itself?
+        markt: In short, no. To correctly handle the error the associated
+               processor needs to set the error flag and catching the exception
+               in the CoyoteAdaptor prevents that. The processors catch
+               Throwable so nothing extra will slip through.
+               The JkCoyoteHandler is a special case since it is a completely
+               different implementation. However, JkCoyoteHandler does need to
+               be changed to catch Throwable rather than Exception. I have
+               updated the proposed patch to do exactly that. 
   -0: schultz: I tend to agree with Konstantin's assertion that the catch
       block is important. I understand the change to the status, but could
       you explain why the catch(Throwable) block has been removed?
+        markt: See reply to kkolino above.
+      
   -1:



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message